-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option to format via context menu #290
Conversation
Related discussion: #322 |
…extension into add-context-menu
Thanks for this. I think |
AutoComplete 😅 . updated now.
Yes. I verified it. There is no changes to existing code and the context-menu script is loaded only in Firefox. |
Thanks for the PR! I'd like to implement #322 before we add any other functionality to the extension. I'm definitely not against considering this in the future once that's completed, but I think it's best to start with the new approach and see what we feel is missing. |
Co-authored-by: Kai Cataldo <[email protected]>
#322 has been merged. We should re-evaluate this in light of the new behavior. |
Thanks @kaicataldo . RightClick to format is a general option available mostly everywhere. I think it would be nice to include the feature. May be with the current changes. I may be even make it work across the browsers. |
I definitely think it's a good idea! I wonder if we can add two context menu options:
Thoughts? |
Yes It is a nice option. Till we figure out language detection. It will be very handy. I do remember giving a thought on this when I was working with this feature. I think there is a limitation. An Extension can have only one context menu option. Adding more than one will automatically group them into sub menus. My memory is little vague on that. I will check and update back |
Yes. It is not possible to render more than one context menu item
https://developer.chrome.com/docs/extensions/reference/contextMenus/#usage |
Closes #20, Partially adresses #21